Code

Notifications redesign#4274

Code

Merged

ouchadam merged 49 commits intodevelopelement-hq/element-android:developfrom feature/adm/notification-redesignelement-hq/element-android:feature/adm/notification-redesignCopy head branch name to clipboardOct 26, 2021

+1,777-650

Commits

Commits on Oct 26, 2021

• avoiding dispatching invitation accepted events

  Show description for e95d49a
  ouchadam

  committed
  e95d49a

  Copy full SHA for e95d49a

• now that we ignore duplicated invite joined events at the source we can avoid eager notification cancels and rely on the main notification refresh flow

  ouchadam

  committed
  0c809b5

  Copy full SHA for 0c809b5

• moving invitiation joined event filtering to the existing mapNotNull chain to avoid another list creation

  ouchadam

  committed
  37a7d44

  Copy full SHA for 37a7d44

• moving is invitation help to the event file

  ouchadam

  committed
  1c0d696

  Copy full SHA for 1c0d696

• removing unused commented code

  ouchadam

  committed
  6721160

  Copy full SHA for 6721160

• removing non common properties form the base event

  ouchadam

  committed
  51f7dee

  Copy full SHA for 51f7dee

• making non overriden properties immutable by passing the values intro the constructor

  ouchadam

  committed
  81da185

  Copy full SHA for 81da185

• removing unused property (written to but never read)

  ouchadam

  committed
  89d643a

  Copy full SHA for 89d643a

• making the isRedacted event property immutable

  Show description for c99dd4a
  ouchadam

  committed
  c99dd4a

  Copy full SHA for c99dd4a

• making the noisy property immutable

  ouchadam

  committed
  db5d4ea

  Copy full SHA for db5d4ea

• separating the mutable vars from the immutable ones, they'll be removed or made immutable by the notification redesign

  ouchadam

  committed
  b44a382

  Copy full SHA for b44a382

• updating the push gateway property to reflect that it mean the event can be replaced

  Show description for 86b5004
  ouchadam

  committed
  86b5004

  Copy full SHA for 86b5004

• formatting

  ouchadam

  committed
  56e2b79

  Copy full SHA for 56e2b79

• including the room name in the invitation event if the room sumary is available

  ouchadam

  committed
  beff5ab

  Copy full SHA for beff5ab

• adding changelog entry

  ouchadam

  committed
  6cc6cc5

  Copy full SHA for 6cc6cc5

• making the event body non null and immutable to allow less cases to be handled -

  Show description for 4459aab
  ouchadam

  committed
  4459aab

  Copy full SHA for 4459aab

• creating dedicated class for the processing the serialized events

  Show description for 7b0c483
  ouchadam

  committed
  7b0c483

  Copy full SHA for 7b0c483

• creating the notifications separate to where they're displayed

  Show description for 0f4ec65
  ouchadam

  committed
  0f4ec65

  Copy full SHA for 0f4ec65

• chaining the event process, notification creation and display logic into a NotificationRender

  Show description for 3023cb4
  ouchadam

  committed
  3023cb4

  Copy full SHA for 3023cb4

• lifting settings change to cancel all notifications out of the renderer

  Show description for c85afa9
  ouchadam

  committed
  c85afa9

  Copy full SHA for c85afa9

• removing no longer needed hasBeenDisplayed state, the eventList is our source of truth

  Show description for 3d567d0
  ouchadam

  committed
  3d567d0

  Copy full SHA for 3d567d0

• handling creating the summary when notification events are filtered to empty due to only containing removals

  ouchadam

  committed
  0d316e6

  Copy full SHA for 0d316e6

• removing this usages for project convention

  ouchadam

  committed
  8fb6bef

  Copy full SHA for 8fb6bef

• formatting

  ouchadam

  committed
  a94a1a0

  Copy full SHA for a94a1a0

• ensuring that we removing the summary group before removing individual notifications

  Show description for 03fe45d
  ouchadam

  committed
  03fe45d

  Copy full SHA for 03fe45d

• relying on the notification refreshing to cancel/update the notifications

  ouchadam

  committed
  587466e

  Copy full SHA for 587466e

• splitting the event processing from the rendering

  Show description for b7b4c01
  ouchadam

  committed
  b7b4c01

  Copy full SHA for b7b4c01

• using a process state of keep/removed rather than mapping to an ignored event id

  Show description for b27fb26
  ouchadam

  committed
  b27fb26

  Copy full SHA for b27fb26

• diffing the notification events against the currently rendered events allow us to dismiss notifications from removed events

  ouchadam

  committed
  0bdc65b

  Copy full SHA for 0bdc65b

• ensuring that we remove read messages when they come through by respecting the processed type when creating the notifications

  ouchadam

  committed
  c67b9ee

  Copy full SHA for c67b9ee

• adding documentation around the two notifiable event lists which act as our notification source of truth

  ouchadam

  committed
  4bbb637

  Copy full SHA for 4bbb637

• fixing line lengths

  ouchadam

  committed
  9fa09de

  Copy full SHA for 9fa09de

• adding missing fixture parameter from rebase

  ouchadam

  committed
  86ce6a4

  Copy full SHA for 86ce6a4

• inlining single use extension functions

  ouchadam

  committed
  4748a38

  Copy full SHA for 4748a38

• adding missing parameter from rebase and removing no longer needed singleton annotation

  ouchadam

  committed
  c16e3e0

  Copy full SHA for c16e3e0

• replacing notification utils usage with the displayer and removing unused method

  ouchadam

  committed
  a6e47d8

  Copy full SHA for a6e47d8

• removing unused imports

  ouchadam

  committed
  6fb7faa

  Copy full SHA for 6fb7faa

• updating tests with shortcut placement changes

  ouchadam

  committed
  63090ef

  Copy full SHA for 63090ef

• increase enum class allowance by 1

  ouchadam

  committed
  d3234b3

  Copy full SHA for d3234b3

• using dedicated ProcessedEvent data class instead of type alias for passing around the process notificatiable events

  Show description for d1f6db4
  ouchadam

  committed
  d1f6db4

  Copy full SHA for d1f6db4

• renaming event lists to give more context and remove the list suffix/inconsistencies

  ouchadam

  committed
  743a71c

  Copy full SHA for 743a71c

• adding changelog entries

  ouchadam

  committed
  e8bd27e

  Copy full SHA for e8bd27e

• Do not use the room member avatar as a room avatar

  

  bmarty

  authored and

  ouchadam

  committed
  c56101d

  Copy full SHA for c56101d

• Compact code

  

  bmarty

  authored and

  ouchadam

  committed
  2bd2cbf

  Copy full SHA for 2bd2cbf

• Tiny formatting

  

  bmarty

  authored and

  ouchadam

  committed
  be67836

  Copy full SHA for be67836

• avoiding multiple list iterations via mapNotNull

  ouchadam

  committed
  b146501

  Copy full SHA for b146501

• removing redacted events from the room notification message list

  ouchadam

  committed
  a5fe6f7

  Copy full SHA for a5fe6f7

• filtering out redacted simple message events, we handle them by updating the notifications

  ouchadam

  committed
  6d9877d

  Copy full SHA for 6d9877d

• adding changelog entry

  ouchadam

  committed
  124061e

  Copy full SHA for 124061e