Fix always empty search results when using a backend that doesn't ret…

…urn highlights

This notably happens with Synapse on SQLite.

changelog.d/8729.bugfix

@@ -0,0 +1 @@
+Fix search results always being empty when using a backend that doesn't return highlights (e.g. Synapse on SQLite)

vector/src/main/java/im/vector/app/features/home/room/detail/search/SearchResultController.kt

@@ -148,6 +148,13 @@ class SearchResultController @Inject constructor(
      */
     private fun setHighLightedText(text: String, highlights: List<String>): Spannable? {
         val wordToSpan: Spannable = SpannableString(text)
+
+        // Some backends don't return highlights at all (this is the case of Synapse with the SQLite storage).
+        // In this case, don't attempt to filter based on the highlights, to avoid erasing all the results...
+        if (highlights.isEmpty()) {
+            return wordToSpan
+        }
+
         var found = false
         highlights.forEach { highlight ->
             var searchFromIndex = 0