-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update avatar colors to the new semantic ones in Compound #81
Conversation
ff71613
to
30836c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised that the colors are identical for light or dark. Maybe an issue in the code (see my other comment)
ElementTheme { | ||
internal fun AvatarColorsPreviewDark() { | ||
val chunks = avatarColors().chunked(4) | ||
ElementTheme(darkTheme = true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The avatarColors()
should be invoked inside the ElementTheme
block maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fixed in 91270a4. Nice catch!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
I also needed to change the signature to a single composable function.