Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create diamond-handing.toml #837

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Create diamond-handing.toml #837

merged 3 commits into from
Dec 22, 2023

Conversation

julianhzhu
Copy link
Contributor

Add Diamond Handing repos

eherrerosj
eherrerosj suggested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a Solana project? If so, could you add it to the list of sub-ecosystems in the solana.toml file please?

@eherrerosj
Copy link
Contributor

looks like a Solana project? If so, could you add it to the list of sub-ecosystems in the solana.toml file please?

you need to keep the toml you created previously. Basically:

  1. Create toml file
  2. Add the title in the toml file to the list of sub-ecos in Solana
  3. No need to add the orgs/repos of the toml file in Solana, our ETL takes care of that

eherrerosj
eherrerosj approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@eherrerosj eherrerosj merged commit 23f39d7 into electric-capital:master Dec 22, 2023
1 check passed
platonicsocrates pushed a commit to platonicsocrates/crypto-ecosystems that referenced this pull request Dec 23, 2023
@julianhzhu @platonicsocrates
Create diamond-handing.toml (electric-capital#837)
668ab4c 
* Add Diamond Handing to Solana projects instead

* Create diamond-handing.toml

* Remove repos from solana.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eherrerosj eherrerosj eherrerosj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianhzhu @eherrerosj