Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(add proto-kit and kaupang to mina) #614

Closed
wants to merge 0 commits into from
Closed

chore(add proto-kit and kaupang to mina) #614

wants to merge 0 commits into from

Conversation

teddyjfpender
Copy link
Contributor

Adding two new sub-ecosystems and their repositories to mina-protocol.toml - Protokit and Kaupang.

eherrerosj
eherrerosj suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you already added the repos in the child ecosystems, there's no need to add them to the parent. Can you please remove the repos from Mina that are already in the childs?

data/ecosystems/m/mina-protocol.toml Outdated Show resolved Hide resolved
@teddyjfpender
Copy link
Contributor Author

@eherrerosj Is there anything else I need to do? :)

@eherrerosj
Copy link
Contributor

@eherrerosj Is there anything else I need to do? :)

could you please fix the conflicts? We merged a pretty big PR coming from our internal changes and it generated a few conflicts with previously opened PRs. Once you are done I'll merge, thx!

@eherrerosj eherrerosj added the waiting Waiting for requester to reply or do some improvements label Nov 7, 2023
@teddyjfpender teddyjfpender mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eherrerosj eherrerosj eherrerosj requested changes

Assignees
No one assigned
Labels
waiting Waiting for requester to reply or do some improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teddyjfpender @eherrerosj