Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshen up subecosystems of Moonriver #613

Merged
merged 39 commits into from
Nov 20, 2023

Conversation

themacexpert
Copy link
Contributor

This PR freshens a variety of ecosystems, adding missed repos and removing stale ones. This PR does not modify what is considered a subecosystem of Moonriver network.

@themacexpert
Copy link
Contributor Author

@eherrerosj Hey, is there anything I need to fix here?

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR, left a couple comments

data/ecosystems/b/bware-labs.toml Outdated Show resolved Hide resolved
data/ecosystems/o/onfinality.toml Outdated Show resolved Hide resolved
@eherrerosj eherrerosj added the waiting Waiting for requester to reply or do some improvements label Nov 7, 2023
@eherrerosj
Copy link
Contributor

hey @themacexpert, you think we could add a missing tag instead of removing repos that don't exist anymore publicly? We prefer to keep non-existant repos so we know they existed at some point and we can keep their commits.

Example: https://github.com/electric-capital/crypto-ecosystems/blob/master/data/ecosystems/h/helios-labs.toml#L11

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left another comment

@themacexpert
Copy link
Contributor Author

@eherrerosj Done! The only remaining deletions are instances where repos have been renamed.

@themacexpert
Copy link
Contributor Author

Any other updates I need to make here? Thank you @eherrerosj

@eherrerosj
Copy link
Contributor

Any other updates I need to make here? Thank you @eherrerosj

LGTM now, thank you for the work @themacexpert !

@eherrerosj eherrerosj merged commit d2a2aae into electric-capital:master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting for requester to reply or do some improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants