-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/util migration #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimized and refactored several methods in the BloodNight's command classes and utilities. Code has been transformed to be clearer by replacing ambiguous variable names and reducing unnecessary repetitions. This has improved code maintainability, readability and efficiency.
Optimized and refactored several methods in the BloodNight's command classes and utilities. Code has been transformed to be clearer by replacing ambiguous variable names and reducing unnecessary repetitions. This has improved code maintainability, readability and efficiency.
Expanded and improved CommandUtil functionality in BloodNight. Added new methods 'changeButton' and 'changeableValue' to enhance command options. Removed unnecessary import of ILocalizer. This refactoring simplifies command creation and makes the code more flexible for future changes.
The ManageMobs command handling has been improved for better conciseness and flexibility. The changes include the implementation of new utility methods 'changeButton' and 'changeableValue' to simplify the command options' manipulation. Additionally, unnecessary import of ILocalizer is now removed, contributing to a cleaner codebase.
rainbowdashlabs
had a problem deploying
to
build
February 25, 2024 14:31 — with
GitHub Actions
Failure
A major overhaul of the ManageMobs command handling has resulted in more flexible and concise code. New utility methods 'changeButton' and 'changeableValue' have been introduced, making command options manipulation simpler. Unnecessary import of ILocalizer has also been removed for a cleaner, non-redundant codebase.
rainbowdashlabs
had a problem deploying
to
build
February 25, 2024 16:17 — with
GitHub Actions
Failure
rainbowdashlabs
temporarily deployed
to
build
February 26, 2024 09:10 — with
GitHub Actions
Inactive
rainbowdashlabs
temporarily deployed
to
build
February 26, 2024 09:15 — with
GitHub Actions
Inactive
rainbowdashlabs
temporarily deployed
to
build
February 26, 2024 09:18 — with
GitHub Actions
Inactive
rainbowdashlabs
temporarily deployed
to
build
February 26, 2024 09:59 — with
GitHub Actions
Inactive
rainbowdashlabs
temporarily deployed
to
build
February 26, 2024 10:03 — with
GitHub Actions
Inactive
The command handling has been reworked in both the `ManageMobs` and `ManageNightSelection` classes for simplicity and easier command options manipulation. This involved introducing a new 'changeButton' and 'changeableValue' utility methods and removing the redundant `ILocalizer` import. These changes improve code maintainability and readability.
rainbowdashlabs
had a problem deploying
to
build
February 26, 2024 13:15 — with
GitHub Actions
Failure
Unused imports were removed to minimize the size and complexity of the code. Command handling in the ManageMobs and ManageNightSelection classes has been improved for simplicity and maintainability. New utility methods 'changeButton' and 'changeableValue' were added which simplify command options manipulation.
rainbowdashlabs
had a problem deploying
to
build
February 26, 2024 13:16 — with
GitHub Actions
Failure
rainbowdashlabs
had a problem deploying
to
build
February 26, 2024 13:19 — with
GitHub Actions
Failure
rainbowdashlabs
temporarily deployed
to
build
February 26, 2024 14:15 — with
GitHub Actions
Inactive
rainbowdashlabs
temporarily deployed
to
build
February 26, 2024 14:17 — with
GitHub Actions
Inactive
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #214
Fix #199