Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Removes D4C documentation #6236

Merged
merged 6 commits into from
Nov 27, 2024
Merged

[Serverless] Removes D4C documentation #6236

merged 6 commits into from
Nov 27, 2024

Conversation

benironside
Copy link
Contributor

Fixes #6021 and #6198 — removes the Defend for Containers documentation from serverless. This feature is now deprecated. No ESS changes are needed until v9.0.

Multiple files changed and removed, please refer to the diff.

@benironside benironside added the Docset: Serverless Issues for Serverless Security label Nov 22, 2024
@benironside benironside self-assigned this Nov 22, 2024
@benironside benironside requested a review from a team as a code owner November 22, 2024 20:03
Copy link
Contributor

mergify bot commented Nov 22, 2024

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link

@nick-alayil nick-alayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. Thanks @benironside 👍

Copy link

@nick-alayil nick-alayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove and configuration drift prevention for Cloud Workloads. in line 37 of docs/serverless/billing.asciidoc

@benironside benironside dismissed nick-alayil’s stale review November 26, 2024 18:51

incorporated Nick's request

nick-alayil
nick-alayil previously approved these changes Nov 26, 2024
Copy link

@nick-alayil nick-alayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small capitalization nit, otherwise LGTM!

@benironside benironside enabled auto-merge (squash) November 27, 2024 20:43
@benironside benironside merged commit 44b15bd into main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Docset: Serverless Issues for Serverless Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serverless]: Security - Remove nav step related to ESS context
3 participants