Add support for source mode to various tracks #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c/security, http_logs and tsdb tracks
| "mappings": { | ||
| {% if source_mode %} | ||
| "_source": { | ||
| "mapping.source.mode": {{ source_mode | tojson }} |
There was a problem hiding this comment.
I don't understand this...Did we introduce something I am not aware of?
There was a problem hiding this comment.
This was a silly mistake on my side.
salvatore-campagna
approved these changes
Oct 22, 2024
elastic/logs/README.md
Outdated
| @@ -221,6 +221,7 @@ The following parameters are available: | |||
| * `lifecycle` (default: unset to fall back on Serverless detection) - Specifies the lifecycle management feature to use for data streams. Use `ilm` for index lifecycle management or `dlm` for data lifecycle management. By default, `dlm` will be used for benchmarking Serverless Elasticsearch. | |||
| * `workflow-request-cache` (default: `true`) - Explicit control of request cache query parameter in searches executed in a workflow. This can be further overriden at an operation level with `request-cache` parameter. | |||
| * `synthetic_source_keep` (default: unset) - Allows overriding the default synthetic source behaviour for all field types with the following values: `none` (equivalent to unset) - no source is stored, `arrays` - source stored as is only for multi-value (array) fields. | |||
| * `source_mode` (default: unset) - Specified the source mode to be used. | |||
There was a problem hiding this comment.
nit: "Specifies"?
elastic/security/README.md
Outdated
| @@ -85,6 +85,7 @@ The following parameters are available: | |||
| * `corpora_uri_base` (default: `https://rally-tracks.elastic.co`) - Specify the base location of the datasets used by this track. | |||
| * `index_mode` (default: unset) - A parameter meant to be used internally which defines one of the available indexing modes, "standard", "logsdb" or "time_series". If not set, "standard" is used. | |||
| * `synthetic_source_keep` (default: unset) - Allows overriding the default synthetic source behaviour for all field types with the following values: `none` (equivalent to unset) - no source is stored, `arrays` - source stored as is only for multi-value (array) fields. | |||
| * `source_mode` (default: unset) - Specified the source mode to be used. | |||
There was a problem hiding this comment.
nit same here and in other places
| @@ -20,6 +20,9 @@ | |||
| {%- else %} | |||
| "_source": { | |||
| "enabled": {{ source_enabled | default(true) | tojson }} | |||
| {% if source_mode %} | |||
There was a problem hiding this comment.
Why is the setting missing in this track?
|
LGTM: I just left a few nits and a question about http_logs. |
martijnvg
changed the title
martijnvg
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Add support for source mode to elastic/logs, elastic/security and http_logs. (cherry picked from commit ae63824)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
martijnvg
pushed a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for source mode to elastic/logs, elastic/security and http_logs.