forked from eclipse-iceoryx/iceoryx2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#458] handle stale shm state files on windows #1
Closed
elfenpiff
wants to merge
279
commits into
ekxide:main
from
elfenpiff:iox2-458-corrupted-service-cleanup
Closed
[#458] handle stale shm state files on windows #1
elfenpiff
wants to merge
279
commits into
ekxide:main
from
elfenpiff:iox2-458-corrupted-service-cleanup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e suggested by SlotMap
…fail when the maximum amount of reallocations was exceeded
…s without 'no_std'
…es without 'no_std'
…re-instead-of-std [eclipse-iceoryx#579] [eclipse-iceoryx#581] Use 'core' and 'alloc' instead of 'std'
…g no longer exists.
…-introspection-interface [eclipse-iceoryx#585] Extend introspection interface
…oadmap [eclipse-iceoryx#4] Update roadmap
…ted-services-cleanup [eclipse-iceoryx#458] corrupted services cleanup
…cess-to-attributes [eclipse-iceoryx#590] easier access to attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
On Windows we have to create additional shm state files to track the size of the shared memory. When a process dies, those files keep living - but the shared memory is removed by the OS. So when another instance wants to create a shared memory with the same name, then it thinks it already exists since the stale state file is still around.
With this adjustments, the state file create function checks if the shm is actually present, if not, it deletes the old state file and creates a new one which fixes the issue.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to eclipse-iceoryx#458