Fix an issue with the banner dialog being dereferenced

ejeschke · Jan 10, 2024 · 7836c0f · 7836c0f
1 parent 2c51639
commit 7836c0f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ginga/rv/Control.py b/ginga/rv/Control.py
@@ -1505,7 +1505,7 @@ def banner(self):
                              buttons=[["Close", 0]], modal=False)
 
         def _close_banner(*args):
-            top.delete()
+            self.ds.remove_dialog(top)
 
         top.add_callback('activated', _close_banner)
         vbox = top.get_content_area()
@@ -1524,7 +1524,7 @@ def _close_banner(*args):
         vbox.add_widget(w, stretch=1)
 
         viewer.set_image(image)
-        top.show()
+        self.ds.show_dialog(top)
 
     def remove_image_by_name(self, chname, imname, impath=None):
         channel = self.get_channel(chname)
@@ -1742,7 +1742,7 @@ def add_menus(self, holder):
 
         item = helpmenu.add_name("About")
         item.add_callback('activated',
-                          lambda *args: self.banner(raiseTab=True))
+                          lambda *args: self.banner())
 
         item = helpmenu.add_name("Documentation")
         item.add_callback('activated', lambda *args: self.help())