Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cluster information in AnalysisEpic #288

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cpecar
Copy link
Contributor

@cpecar cpecar commented Jul 12, 2023

Briefly, what does this PR introduce?

In ePIC simulation version 23.07.1, cluster associations are created.

ReconstructedParticles collection now contains particles from clusters not associated with a track, so should at least be used for HFS methods.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

ReconstructedParticles collection was filled with zeros for versions prior to 23.07.1, so this would break for old simulation versions without some method to check which is being used.

Does this PR change default behavior?

No.

@cpecar cpecar added the fullsim label Jul 12, 2023
@cpecar cpecar marked this pull request as draft July 12, 2023 19:11
Base automatically changed from prod-23.07.1 to main July 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant