HLM-638 | Code reafctoring 3

egovernments · Sep 21, 2022 · c301770 · c301770
1 parent c1853d0
commit c301770
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/backend/vc-certification-service/src/controllers/certificate.controller.js b/backend/vc-certification-service/src/controllers/certificate.controller.js
@@ -4,7 +4,7 @@ const sunbirdRegistryService = require('../services/sunbird.service')
 const certifyConstants = require('../configs/constants');
 const {validationResult} = require('express-validator');
 const validationService = require('../services/validation.service');
-const {truncateShard, checkIfArray} = require("../utils/certification.utils");
+const {truncateShard, extractFromArray} = require("../utils/certification.utils");
 
 const REVOKED = "REVOKED";
 const SUSPENDED = "SUSPENDED";
@@ -162,8 +162,8 @@ async function verifyCertificate (req,res){
         signedCredentials : certificate,
     }
     try{
-        const certificateEntityType = checkIfArray(checkIfArray(certificate.evidence).type);
-        const certificateId = checkIfArray(certificate.evidence).certificateId;
+        const certificateEntityType = extractFromArray(extractFromArray(certificate.evidence).type);
+        const certificateId = extractFromArray(certificate.evidence).certificateId;
         console.log({certificateEntityType: certificateEntityType, certificateId:certificateId });
 
         const verifyResp = await sunbirdRegistryService.verifyCertificate(body)

diff --git a/backend/vc-certification-service/src/utils/certification.utils.js b/backend/vc-certification-service/src/utils/certification.utils.js
@@ -1,7 +1,7 @@
 const truncateShard = (osId) => {
     return osId?.substring(2);
 }
-const checkIfArray = (object) => {
+const extractFromArray = (object) => {
     if (object) {
         object = Array.isArray(object) ? object[0] : object;
     } else {
@@ -11,5 +11,5 @@ const checkIfArray = (object) => {
 }
 module.exports = {
     truncateShard,
-    checkIfArray
+    extractFromArray
 }