Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PRDE-842): Upgrade [email protected] (with fixes) #13

Merged
merged 30 commits into from
Feb 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
95db107
Allow branch protection to be applied on default branch creation on n…
jaekunchoi Oct 18, 2023
1540810
Changes for handling org level rulesets (#519)
decyjphr Oct 18, 2023
4cca3b0
Update the context to handle context.repo for org-level webhooks (#539)
decyjphr Oct 19, 2023
64d21b6
Bump @babel/traverse from 7.21.3 to 7.23.2 (#538)
dependabot[bot] Oct 30, 2023
e584dbc
Add support for GitHub Environments (#544)
avelizmu Oct 30, 2023
f5408a4
add outer try-catch fix issue #545 (#546)
decyjphr Dec 8, 2023
6662091
Go back environments again (#567)
svg153 Dec 8, 2023
936ec2d
Bump octokit from 3.1.0 to 3.1.2 (#575)
dependabot[bot] Jan 3, 2024
b8abc1b
Bump probot from 12.3.1 to 12.3.3 (#573)
dependabot[bot] Jan 3, 2024
6c297f2
Allow github context in configValidator and overrideValidator (#584)
sshrestha02 Feb 5, 2024
94b3349
update references to have allow_update_branch (#560)
bheemvennapureddy Feb 6, 2024
15d45c8
Merge branch 'main-enterprise' into upgrade-2.1.4
stevoland Feb 9, 2024
8973e31
fix: hardcoded .github reference --> CONFIG_PATH
stevoland Feb 9, 2024
11f7f1f
fix: Handle error creating PR comment
stevoland Feb 9, 2024
2611aac
feat: Remove NOOP actions due to partial sync from PR comments
stevoland Feb 9, 2024
2f3e21d
fix: Strip whitespace from noop comments
stevoland Feb 9, 2024
2d5c0fb
docs: Add internal changes to readme
stevoland Feb 9, 2024
0628d91
fix: diffable broken after mergeDeep change
stevoland Feb 9, 2024
2382604
test: Fix env tests
stevoland Feb 9, 2024
e7b9abc
test: Skip failing validator tests
stevoland Feb 9, 2024
849b2fd
test: Remove test workaround
stevoland Feb 9, 2024
a340b49
fix: Ignore archived repos
stevoland Feb 9, 2024
0876f11
chore: jest-junit as dev dep
stevoland Feb 9, 2024
ad5b003
docs: Readme updates
stevoland Feb 9, 2024
d70fb7f
Disable environments due to https://github.com/github/safe-settings/i…
stevoland Feb 10, 2024
4210f66
Fix mergeDeep calls in plugins
stevoland Feb 10, 2024
bf9c632
Fix repository unit tests
stevoland Feb 10, 2024
fedfe9d
Fix validator unit tests
stevoland Feb 10, 2024
00ea79b
Fix branches unit tests
stevoland Feb 10, 2024
adab987
Disable milestones
stevoland Feb 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: Remove test workaround
stevoland committed Feb 9, 2024
commit 849b2fd4e942ff9709c455b5cabbbd9f5a266282
5 changes: 1 addition & 4 deletions test/unit/lib/plugins/autolinks.test.js
Original file line number Diff line number Diff line change
@@ -45,9 +45,6 @@ describe('Autolinks', () => {
{ id: '7', key_prefix: 'NEW_ALPHA-UNDEFINED-', url_template: 'https://test/<num>', is_alphanumeric: false },
{ id: '8', key_prefix: 'NEW_ALPHA-FALSE-', url_template: 'https://test/<num>', is_alphanumeric: true },
{ id: '9', key_prefix: 'NEW_ALPHA-TRUE-', url_template: 'https://test/<num>', is_alphanumeric: false },
// todo: Remove when https://github.com/github/safe-settings/issues/521 is resolved:
// Currently, the number of entries/existing records must be different for updates to be made
{ id: '10', key_prefix: 'REMOVE-HACK-', url_template: 'https://test/<num>', is_alphanumeric: true },
]
})

@@ -141,7 +138,7 @@ describe('Autolinks', () => {
...repo
})

expect(github.repos.deleteAutolink).toHaveBeenCalledTimes(6)
expect(github.repos.deleteAutolink).toHaveBeenCalledTimes(5)
expect(github.repos.createAutolink).toHaveBeenCalledTimes(5)
})
})