Added support for the system stats query endpoint. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriq-augustine
force-pushed
the
eriq-stats
branch
from
e9576ad to
316fadb
Compare
OliverLok
reviewed
Jan 5, 2025
OliverLok
reviewed
Jan 5, 2025
| }, | ||
| "courses/assignments/submissions/remove": { | ||
| "request-type": "*submissions.RemoveRequest", | ||
| "response-type": "*submissions.RemoveResponse" | ||
| "response-type": "*submissions.RemoveResponse", | ||
| "description": "Remove a specified submission. Defaults to the most recent submission." |
There was a problem hiding this comment.
Is there a reason this is the only endpoint that says what it defaults to, because there are others (E.g. peek) that also default to the most recent submission.
There was a problem hiding this comment.
(Note that this is not the PR for this discussion, but it's okay since this is not a very formal PR.)
Probably since this one is a lot more serious than the other ones.
We can decide if they all should have them but this one is serious biz (and cannot be taken back),
so it makes sense for it to be more verbose.
OliverLok
suggested changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling Server PR: edulinq/autograder-server#136