-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API Endpoint: users/upsert #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking real good.
Much cleaner and clearer than our pre-split version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Just a small things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR implements the python interface for the new API endpoint users/upsert.
Users upsert allows server admin or above to upsert (update if exists, insert otherwise) users to the server.
Users/upsert is for upserting a single user, whereas users/upsert-file is for bulk upserting users.
This PR must be reviewed with the associate users/upsert server side PR.