Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API Endpoint: users/upsert #25

Merged
merged 18 commits into from
Sep 26, 2024
Merged

Conversation

Lucas-Ellenberger
Copy link
Contributor

This PR implements the python interface for the new API endpoint users/upsert.

Users upsert allows server admin or above to upsert (update if exists, insert otherwise) users to the server.

Users/upsert is for upserting a single user, whereas users/upsert-file is for bulk upserting users.

This PR must be reviewed with the associate users/upsert server side PR.

Copy link
Collaborator

@eriq-augustine eriq-augustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking real good.

Much cleaner and clearer than our pre-split version.

autograder/api/users/upsert.py Outdated Show resolved Hide resolved
autograder/cli/users/upsert-file.py Show resolved Hide resolved
autograder/cli/users/upsert-file.py Show resolved Hide resolved
autograder/cli/users/upsert-file.py Outdated Show resolved Hide resolved
autograder/cli/users/upsert-file.py Outdated Show resolved Hide resolved
tests/cli/testdata/users/users_upsert_add.txt Show resolved Hide resolved
Copy link
Collaborator

@eriq-augustine eriq-augustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Just a small things.

autograder/cli/users/upsert.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@eriq-augustine eriq-augustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eriq-augustine eriq-augustine merged commit c7ca0f6 into edulinq:main Sep 26, 2024
31 checks passed
@Lucas-Ellenberger Lucas-Ellenberger deleted the upsert branch September 29, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants