fix: use own, newly created directory #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruebing
force-pushed
the
max/10-09-specific-dir
branch
from
dd8c7fe to
da9f340
Compare
ccoVeille
reviewed
Oct 9, 2024
src/index.ts
Outdated
| @@ -5,22 +5,33 @@ import path from 'node:path' | |||
| import { findRelease } from './release' | |||
| import { checkerName, version } from './shared' | |||
|
|
|||
| const WORKING_DIR = path.join(process.env.HOME ?? "/tmp", 'editorconfig-checker') | |||
There was a problem hiding this comment.
Is there any reason to do not use /tmp by default?
Couldn't we use a temporary working directory? Something equivalent to mktemp -d (shell) or os.TempDir (Go) ?
There was a problem hiding this comment.
If we would like to use /tmp, we should use os.tmpdir().
There was a problem hiding this comment.
I‘ve used that as a fallback because the environment variable could be undefined. I doubt that it ever will be, but yeah, we should guard against it.
theoludwig
reviewed
Oct 9, 2024
mstruebing
force-pushed
the
max/10-09-specific-dir
branch
from
67bb068 to
79fe996
Compare
|
cc @rskmm0chang |
theoludwig
approved these changes
Oct 9, 2024
klaernie
approved these changes
Oct 9, 2024
Co-authored-by: Théo LUDWIG <[email protected]>
mstruebing
force-pushed
the
max/10-09-specific-dir
branch
from
79fe996 to
da5944d
Compare
|
I guess 72hours are over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure how to test this properly.
Closes #129