Return information about extracted constants from pg_query_normalize
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PgQueryNormalizeResult` now includes information about the extracted constants, their location and extent, as well as the lexer token type and the value of constants as interpreted by the lexer. This makes `pg_query_normalize` usable not just for query identification, but also as a basis for automatic conversion of literal queries into constant-agnostic prepared statements or other applications where auto-parametrization of queries is useful. This also makes `pg_query_normalize` to use `base_yylex` instead of `core_yylex` which normalizes `USCONST` constants properly.
elprans
force-pushed
the
pg-normalize-report-constants
branch
from
3931efb to
a8cb6f4
Compare
msullivan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PgQueryNormalizeResultnow includes information about the extractedconstants, their location and extent, as well as the lexer token type
and the value of constants as interpreted by the lexer. This makes
pg_query_normalizeusable not just for query identification, but alsoas a basis for automatic conversion of literal queries into
constant-agnostic prepared statements or other applications where
auto-parametrization of queries is useful.
This also makes
pg_query_normalizeto usebase_yylexinstead ofcore_yylexwhich normalizesUSCONSTconstants properly.