Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform][AS7326-56X]: Fix status led test failed for FAN and PSU. #68

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

tigerfu000
Copy link
Contributor

Why I did it

sonic-mgmt pytest failed on

  • platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_led
  • platform_tests/api/test_fan_drawer.py::TestFanDrawerApi::test_set_fan_drawers_led
  • platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_led
  • platform_tests/api/test_psu.py::TestPsuApi::test_led

How I did it

Correct settings for platform.json because the status LEDs for PSU and FAN are uncontrollable.

How to verify it

Re-run the pytest and the result is pass.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Why I did it:
  sonic-mgmt pytest failed on
  - platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_led
  - platform_tests/api/test_fan_drawer.py::TestFanDrawerApi::test_set_fan_drawers_led
  - platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_led
  - platform_tests/api/test_psu.py::TestPsuApi::test_led

How I dit it:
  Correct settings for platform.json because the status LEDs for PSU and FAN are uncontrollable.

How to verify it:
  Re-run the pytest and the result is pass.
@kevin28-9219 kevin28-9219 self-requested a review July 4, 2024 01:43
@kevin28-9219 kevin28-9219 merged commit 7944b52 into edge-core:202311.0 Jul 4, 2024
1 check passed
@tigerfu000 tigerfu000 deleted the 202311.0_as7326-56x branch August 22, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants