Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform][AS5835-54X] Fix sonic-mgmt pytest fail for chassis_fans, fan_drawer, and fan_drawer_fans #185

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

tigerfu000
Copy link
Contributor

@tigerfu000 tigerfu000 commented Sep 9, 2024

Why I did it

  • Fix pytest fail:
    • platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_led
    • platform_tests/api/test_fan_drawer.py::TestFanDrawerApi::test_set_fan_drawers_led
    • platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_led

How I did it

  • Add 'controllable'=false in platform.json to fix these failures because platform does not support.

How to verify it

  • Run pytest cases is pass.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@kevin28-9219 kevin28-9219 merged commit 54667b9 into edge-core:202311.0 Sep 9, 2024
1 check passed
@tigerfu000 tigerfu000 deleted the 2311.0_pytest_chassis branch September 9, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants