Skip to content

Commit

Permalink
[Platform][AS7326-56X]: Fix status led test failed for FAN and PSU.
Browse files Browse the repository at this point in the history
Why I did it:
  sonic-mgmt pytest failed on
  - platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_led
  - platform_tests/api/test_fan_drawer.py::TestFanDrawerApi::test_set_fan_drawers_led
  - platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_led
  - platform_tests/api/test_psu.py::TestPsuApi::test_led

How I dit it:
  Correct settings for platform.json because the status LEDs for PSU and FAN are uncontrollable.

How to verify it:
  Re-run the pytest and the result is pass.
  • Loading branch information
tiger_fu committed Jul 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 1ea392b commit 0a055cd
Showing 1 changed file with 104 additions and 2 deletions.
106 changes: 104 additions & 2 deletions device/accton/x86_64-accton_as7326_56x-r0/platform.json
Original file line number Diff line number Diff line change
@@ -28,203 +28,293 @@
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-1R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-2F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-2R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-3F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-3R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-4F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-4R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-5F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-5R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-6F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-6R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
}
],
"fan_drawers":[
{
"name": "FanTray1",
"status_led": {
"controllable": false
},
"num_fans" : 2,
"fans": [
{
"name": "FAN-1F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-1R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
}
]
},
{
"name": "FanTray2",
"status_led": {
"controllable": false
},
"num_fans" : 2,
"fans": [
{
"name": "FAN-2F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-2R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
}
]
},
{
"name": "FanTray3",
"status_led": {
"controllable": false
},
"num_fans" : 2,
"fans": [
{
"name": "FAN-3F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-3R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
}
]
},
{
"name": "FanTray4",
"status_led": {
"controllable": false
},
"num_fans" : 2,
"fans": [
{
"name": "FAN-4F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-4R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
}
]
},
{
"name": "FanTray5",
"status_led": {
"controllable": false
},
"num_fans" : 2,
"fans": [
{
"name": "FAN-5F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-5R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
}
]
},
{
"name": "FanTray6",
"status_led": {
"controllable": false
},
"num_fans" : 2,
"fans": [
{
"name": "FAN-6F",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
},
{
"name": "FAN-6R",
"speed": {
"controllable": true,
"minimum": 32
},
"status_led": {
"controllable": false
}
}
]
@@ -233,9 +323,15 @@
"psus": [
{
"name": "PSU-1",
"status_led": {
"controllable": false
},
"fans": [
{
"name": "PSU-1 FAN-1"
"name": "PSU-1 FAN-1",
"status_led": {
"controllable": false
}
}
],
"thermals": [
@@ -253,9 +349,15 @@
},
{
"name": "PSU-2",
"status_led": {
"controllable": false
},
"fans": [
{
"name": "PSU-2 FAN-1"
"name": "PSU-2 FAN-1",
"status_led": {
"controllable": false
}
}
],
"thermals": [

0 comments on commit 0a055cd

Please sign in to comment.