Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change VMS lane state by os methods #456

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

hoelger
Copy link
Contributor

@hoelger hoelger commented Jan 9, 2025

Description

OS now offers methods to adjust lane assignments and speed assignments for VMS

Issue(s) related to this PR

  • Done in context of issue 940, though not very tightly coupled

Affected parts of the online documentation

Changes in the documentation required? Yes, we can mention the helper functions.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@hoelger hoelger force-pushed the 940-change-lane-state-by-os branch 2 times, most recently from e24ce0a to 2a56b57 Compare January 9, 2025 11:10
@hoelger hoelger force-pushed the 940-change-lane-state-by-os branch from 2a56b57 to 951ddc4 Compare January 13, 2025 10:11
@kschrab kschrab merged commit d9cb9ec into eclipse:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants