feat: Refactor CellMessageRoutingBuilder #436
Conversation
This reverts commit 648011c.
…ipse#423) * build: store etc-files in mosaic-starter and copy them to bundle and integration tests * clean: remove unnecessary properties from copy-resources definition
* ci: use SUMO 1.21.0 for testing * feat(sumo): support SUMO 1.21.0 Added hint, that SUMO_HOME/bin must be present in the PATH variable. Pre-loading some libraries is not required anymore then.
* refactor: don't use this whenever possible
… routing (eclipse#428) * feat(sns): cleanup, minor performance improvement for flooding (early exit if flooding could not be progressed)
…nts (eclipse#420) * feat: introducing SensorModule to provide access to environmental events * feat(application): allow registration of callback for lidar sensor module * feat(application): re-use Perceptive interface for accessing new sensor modules
| return destination(new NetworkAddress(NetworkAddress.BROADCAST_ADDRESS)); | ||
| } | ||
|
|
||
| public CellMessageRoutingBuilder mbs() { |
There was a problem hiding this comment.
what if I call broadcast().topological().mbs()?
I think you need to add Valitate.isTrue(routing != DestinationType.CELL_TOPOCAST, "MBS can only be activated for geographical routing.")
There was a problem hiding this comment.
Yes that would be correct. I also just saw the case where we call .destination(xy).mbs().build(). This would work, as all checks pass, but we would not have the geographical area for the mbs. This is only given if we also add .geographical(area) to the builder. Should we allow mbs to have an area parameter or should I check for this case separatley?
There was a problem hiding this comment.
Should we allow mbs to have an area parameter or should I check for this case separatley?
You mean, if we should enforce it (you wrote "allow")? I think so. You can check that (and more?) in the checkNecessaryValues method at the end.
Description
CellMessageRoutingBuilderto new standardsWhat is this PR about?
Issue(s) related to this PR
Affected parts of the online documentation
Definition of Done
Prerequisites
Required
type(scope): description(in the style of Conventional Commits)enhancement, orbugfix)origin/mainhas been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer