-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introducing SensorModule to provide access to environmental events #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had a very brief read and came up with following things:
|
# Conflicts: # app/tutorials/traffic-light-communication/src/main/java/org/eclipse/mosaic/app/tutorial/EventSendingApp.java # app/tutorials/weather-warning/src/main/java/org/eclipse/mosaic/app/tutorial/WeatherServerApp.java # app/tutorials/weather-warning/src/main/java/org/eclipse/mosaic/app/tutorial/WeatherWarningApp.java # fed/mosaic-application/src/main/java/org/eclipse/mosaic/fed/application/ambassador/simulation/AbstractSimulationUnit.java
hoelger
reviewed
Oct 7, 2024
...clipse/mosaic/fed/application/ambassador/simulation/sensor/EnvironmentBasicSensorModule.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/mosaic/fed/application/ambassador/simulation/AbstractSimulationUnit.java
Outdated
Show resolved
Hide resolved
rprotzmann
requested changes
Oct 25, 2024
...pplication/src/main/java/org/eclipse/mosaic/fed/application/app/api/os/modules/Sensible.java
Outdated
Show resolved
Hide resolved
...ation/src/main/java/org/eclipse/mosaic/fed/application/app/api/sensor/LidarSensorModule.java
Outdated
Show resolved
Hide resolved
...tion/src/main/java/org/eclipse/mosaic/fed/application/app/api/os/VehicleOperatingSystem.java
Outdated
Show resolved
Hide resolved
...ation/src/main/java/org/eclipse/mosaic/fed/application/app/api/sensor/BasicSensorModule.java
Outdated
Show resolved
Hide resolved
kschrab
force-pushed
the
899-sensor-module
branch
from
October 30, 2024 17:20
bff9f5f
to
c71bcdc
Compare
rprotzmann
approved these changes
Nov 6, 2024
FunKuchen
pushed a commit
to FunKuchen/mosaic
that referenced
this pull request
Nov 12, 2024
…nts (eclipse#420) * feat: introducing SensorModule to provide access to environmental events * feat(application): allow registration of callback for lidar sensor module * feat(application): re-use Perceptive interface for accessing new sensor modules
FunKuchen
pushed a commit
to FunKuchen/mosaic
that referenced
this pull request
Nov 12, 2024
…nts (eclipse#420) * feat: introducing SensorModule to provide access to environmental events * feat(application): allow registration of callback for lidar sensor module * feat(application): re-use Perceptive interface for accessing new sensor modules
schwepmo
pushed a commit
that referenced
this pull request
Dec 2, 2024
…nts (#420) * feat: introducing SensorModule to provide access to environmental events * feat(application): allow registration of callback for lidar sensor module * feat(application): re-use Perceptive interface for accessing new sensor modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BasicSensorModule
is a single-value based sensor model which can be used to detect icy or rainy areas (e.g., viagetOs().getBasicSensorModule().getStrengthOf(SensorType.ICE)
. This replaces the methodgetOs().getStateOfEnvironmentSensor(SensorType.ICE)
in the generalOperatingSystem
. The data for this sensor module is produced by theEnvironmentAmbassador
.LidarSensorModule
provides access to the previously addedPointCloud
structure which is produced by vehicle simulators such as PHABMACS or Carla.VehicleUnit
s are able to use the new sensor modules.WeatherWarningApp
).Issue(s) related to this PR
Affected parts of the online documentation
Changes in the documentation required?
Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer