feat(visualizer): add icons for bicycles and busses in WebVisualizer #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hicles to the map, although there's no position yet
kschrab
reviewed
Sep 26, 2024
kschrab
changed the title
kschrab
reviewed
Sep 27, 2024
There was a problem hiding this comment.
This file is soo big suddenly.. what happened here?
There was a problem hiding this comment.
solved it now! and changed the readme accordingly
schwepmo
pushed a commit
that referenced
this pull request
Dec 2, 2024
…419) * chore: `npm run-script debug` output is now spanning multiple lines * fix: remove double bookkeeping (equippedVehicles) and directly add vehicles to the map, although there's no position yet * fix: take into account the vehicleClass, show 'unknown' if not a car * swap icons * feat: add bicycle and bus icons * refactor: remove line that has no effect * refactor: change tab size from 2 to 4 * fix: only display equipped traffic lights * fix: replace non-existing link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the webVisualizer all vehicles were shown as cars, also if they are bicycles or buses. This PR fixes this, plus minor cleanup.
Issue(s) related to this PR
Affected parts of the online documentation
Only changes in the README, which are here in this PR.
Definition of Done
Prerequisites
Required
type(scope): description(in the style of Conventional Commits)enhancement, orbugfix)origin/mainhas been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer