feat: improve ns3 installer + minor fixes #413
Merged
+38
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschrab
approved these changes
Sep 23, 2024
fed/mosaic-ns3/src/main/java/org/eclipse/mosaic/fed/ns3/ambassador/Ns3Ambassador.java
Show resolved
Hide resolved
hoelger
force-pushed
the
894-setup-ns3
branch
from
5c9b154 to
9a92617
Compare
kschrab
reviewed
Sep 24, 2024
hoelger
force-pushed
the
894-setup-ns3
branch
from
9a92617 to
5ee205f
Compare
hoelger
force-pushed
the
894-setup-ns3
branch
2 times, most recently
from
1fc9bcd to
98d6578
Compare
kschrab
reviewed
Oct 1, 2024
…u download from the URL via browser or CLI)
kschrab
approved these changes
Oct 1, 2024
schwepmo
pushed a commit
that referenced
this pull request
Dec 2, 2024
* feat: fail hard when running ns3 on windows * fix: do not download if the file already exists * fix: remove assumption that glob resolves to only one file * fix: rewrite so that protobuf genereration can be skipped * fix: require protobuf-compiler * fix: improve error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly improves the ns3 installer, to run without problems.
Issue(s) related to this PR
Affected parts of the online documentation
Yes, update the dependencies.
Definition of Done
Prerequisites
Required
type(scope): description(in the style of Conventional Commits)enhancement, orbugfix)origin/mainhas been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer