Add a new spec section to cover integration with opentelemetry metrics #623
Conversation
|
Can one of the admins verify this patch? |
|
|
||
| [source, java] | ||
| ---- | ||
| package com.exmaple; |
| @@ -0,0 +1,298 @@ | |||
| // | |||
| // Copyright (c) 2018-2020 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
I think the date needs updating here
|
|
||
| === Scope | ||
|
|
||
| Metrics added by this specification will appear in the `base` MicroProfile Telemetry scope. |
There was a problem hiding this comment.
Is this [still] a thing with MP Telemetry Metrics?
There was a problem hiding this comment.
Good point
|
@benjamin-confino since this new doc is so similar to the chapter of integrating with MP Metrics, can you rework that chapter and change the heading to Metrics and then call out the difference between the integration with MP Metrics and the one with MP Telemetry? |
|
also you need to update the main doc to add a section saying "Relationship to MicroProfile Telemetry" |
benjamin-confino
force-pushed
the
spec-for-mptel-integration
branch
3 times, most recently
from
e28d6fb to
16c006d
Compare
...a/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/MetricGetterBackup.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
spec-for-mptel-integration
branch
8 times, most recently
from
b5cd00b to
5ab92d7
Compare
.../main/java/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/AllMetricsBean.java
Outdated
Show resolved
Hide resolved
|
@eclipse-microprofile-bot test this please |
.../org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/MetricRegistryProxy.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/MetricDefinition.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/MetricGetter.java
Outdated
Show resolved
Hide resolved
...org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/InMemoryMetricReader.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
spec-for-mptel-integration
branch
from
5f97f23 to
a8edd0c
Compare
...java/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/TelemetryConfigAsset.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/MetricComparator.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
spec-for-mptel-integration
branch
3 times, most recently
from
4112ca4 to
f5a3f5d
Compare
...n/java/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/BulkheadMetricTest.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/microprofile/fault/tolerance/tck/telemetryMetrics/util/CounterMetric.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
spec-for-mptel-integration
branch
3 times, most recently
from
463b11a to
46cd8fc
Compare
benjamin-confino
force-pushed
the
spec-for-mptel-integration
branch
from
46cd8fc to
533df9b
Compare
|
@benjamin-confino please update the copyright dates accordingly. Some new files has the wrong copyright year. |
|
@Emily-Jiang Which files are wrong? In some cases Ben has copied an existing MP Metrics test and made modifications for Telemetry so the old date was retained although the file appears as new in the diff. I did check for wrong dates and didn't spot any. Somewhat related: I did spot some files where the second date in the range should potentially be updated, but the handbook now says we only need the original date anyway. I was planning to remove the second date from all files to match the handbook in another PR. |
You were right. I was commented on the current year. Based on the new version of the handbook, the year of the changes are no longer to be updated. Well spotted. I have approved this PR and you can merge it and do the copyright end year via this issue. |
We still need a section covering what happens if both mpMetrics and mpTelemetry are live.