Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Theia IDE Header #632

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Improve Theia IDE Header #632

merged 2 commits into from
Oct 28, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #631

@JonasHelming
Improve Theia IDE Header
c10bf33 
fixed #631

Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming JonasHelming temporarily deployed to pull-request-preview October 28, 2024 08:32 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-28 15:22 UTC

jfaltermeier
jfaltermeier approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I’m fine with merging as is.
One thing we might consider adjusting is the size of the Theia IDE logo, as it looks a bit small with the new layout. Maybe roughly the same width as the Label?

Before:
ksnip_20241028-130612

After:
ksnip_20241028-130629

@JonasHelming
- Increase size of Theia IDE logo.
d13787b 
- Add margin on top for anker

Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming
Copy link
Contributor Author

Looks good to me, and I’m fine with merging as is. One thing we might consider adjusting is the size of the Theia IDE logo, as it looks a bit small with the new layout. Maybe roughly the same width as the Label?
See new version!

jfaltermeier
jfaltermeier approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JonasHelming JonasHelming merged commit fb5e425 into master Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaltermeier jfaltermeier jfaltermeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Theia IDE Header
2 participants
@JonasHelming @jfaltermeier