-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link issues after hard-reloading pages #547
Conversation
|
On hard reload the URL ending with `xyz/` sometimes becomes `xyz`, which then breaks all relative internal links. With this change, we are adding `gatsby-plugin-catch-links` to ensure internal links work either way. Also we update the readme to reflect where the website is now hosted.
I could reproduce the problem on current master with, .e.g., https://theia-ide.org/docs/services_and_contributions/ and its link to theia-extensions: Hard reload -> click -> 404. After testing several pages (and, additionally, using a link-checking tool), I can confirm that this behavior is gone in the preview of this PR. According to
The ones in blueprint_documentation would not cause issues, the ones in summary.md do but I cannot find where that site is linked/used. |
On hard reload the URL ending with
xyz/
sometimes becomesxyz
, which then breaks all relative internal links. With this change, we are addinggatsby-plugin-catch-links
to ensure internal links work either way. Also we update the readme to reflect where the website is now hosted.