Setup theia folder with example app and config-store skeleton #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a new root-level folder `theia` for all theia extensions, corresponding example extensions and a test browser app. - Monitor Theia extension is not yet moved to new theia folder. - The theia folder uses a copied version of the tsconfig and eslint settings of the node folder. - Initial setup of config-store extension, service and client
- Move monitor-theia extension from node/ to theia/extensions/ - Add monitor-theia to Theia example app - Adapt monitor theia Demo docker file - Add Theia CI workflow to build all Theia extensions and the example app - Add reusable theia extension publish workflow - Adapt monitor extension workflow to only do the publishing
lucas-koehler
force-pushed
the
lk/config-store
branch
from
f69e89a to
f0f235e
Compare
lucas-koehler
requested review from
jfaltermeier and
sgraband
and removed request for
jfaltermeier
|
The license check ran successfully but found 3 deps that still require review from the Eclipse Foundation. They are all MIT or ISC licensed and, thus, should be fine. See https://github.com/eclipse-theia/theia-cloud/actions/runs/12430571020/job/34706262244 : |
jfaltermeier
reviewed
Jan 7, 2025
There was a problem hiding this comment.
The skeleton looks good already. I think the theia directory could use a README explaining the most important commands for building and starting the application.
When I run yarn && yarn start from the theia directory, I encounter the following error:
$ yarn start
yarn run v1.22.22
$ yarn example-app start
$ yarn --cwd examples/browser-app start
$ theia start
Failed to start the backend application:
Error: Could not unbind serviceIdentifier: LocalizationServerImpl
at Container._removeServiceFromDictionary (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1566:19)
at Container.unbind (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1133:14)
at Container.rebind (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1113:14)
at /home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1427:45
at bindMainBackend (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_drivelist_build_Release_drivelist_node-node_modules_eclipse-theiacloud_m-4945d7.js:22985:5)
at ContainerModule.registry (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_drivelist_build_Release_drivelist_node-node_modules_eclipse-theiacloud_m-4945d7.js:24222:53)
at Container.load (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1033:27)
at /home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/main.js:389:29
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async module.exports (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/main.js:427:9)
/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_drivelist_build_Release_drivelist_node-node_modules_eclipse-theiacloud_m-4945d7.js:3544
throw reason;
^
Error: Could not unbind serviceIdentifier: LocalizationServerImpl
at Container._removeServiceFromDictionary (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1566:19)
at Container.unbind (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1133:14)
at Container.rebind (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1113:14)
at /home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1427:45
at bindMainBackend (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_drivelist_build_Release_drivelist_node-node_modules_eclipse-theiacloud_m-4945d7.js:22985:5)
at ContainerModule.registry (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_drivelist_build_Release_drivelist_node-node_modules_eclipse-theiacloud_m-4945d7.js:24222:53)
at Container.load (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/vendors-node_modules_fuzzy_lib_fuzzy_js-node_modules_inversify_es_inversify_js-node_modules_i-9bf063.js:1033:27)
at /home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/main.js:389:29
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async module.exports (/home/johannes/Git/theia-cloud/theia/examples/browser-app/lib/backend/main.js:427:9)
Node.js v20.10.0
Done in 0.78s.
- Consistently use peer dependencies for Theia extensions - Align config store version to 1.1.0-next - Depend on the exact version in the example app to avoid pulling older versions from the registry - Add README describing folder content and important npm scripts - Register config store example's contributions as singletons
|
Hi @jfaltermeier thanks for the review and pointing out the build error. At the point in time of pushing it, it worked for me locally but after a full clean of the folder with I also added a README and did a few more minor improvements. They are noted in the commit message of de4215d |
lucas-koehler
requested review from
jfaltermeier
and removed request for
sgraband
|
Some of the license reviews need manual review though, so we should probably wait until they have been approved |
|
Licenses have been approved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup of config-store extension, example app in new theia folder
theiafor all theia extensions, corresponding example extensions and a test browser app.Move monitor-theia extension to theia folder and setup Theia CI
Add license check for theia folder