Publish maven artifacts to GH Packages #305
Conversation
sgraband
force-pushed
the
mavenPublish
branch
15 times, most recently
from
ace8466 to
07569da
Compare
Provide reusable maven ci workflow. Publish `maven-conf` and `org.eclipse.theia.cloud.common`. Publish `org.eclipse.theia.cloud.operator` and `org.eclipse.theia.cloud.service`. Always resolve `maven-conf` and `org.eclipse.theia.cloud.common` locally. Update `actions/setup-java@v3` to `actions/setup-java@v4`.
sgraband
changed the title
There was a problem hiding this comment.
The workflows already look pretty good to me ✨ . I have two minor suggestions and two questions inline.
We could probably remove the service tests CI as this is now indirectly also called on the maven build. WDYT?
I agree that we can remove it.
The naming on the checks (which are starting to become quite a few) could be improved imho. Maybe in a follow up?
That's true. Yes, we can do a follow up.
Add flags to maven build to clean up logs and execute tests. Improve input description. Remove the service tests, as they are indirectly run via the maven build.
|
Thanks for the feedback. I applied your feedback and removed the service tests. I also created a reminder to discuss the renaming of the ci jobs. |
| jobs: | ||
| call-reusable-maven-workflow: | ||
| permissions: | ||
| packages: write |
There was a problem hiding this comment.
I'm a bit surprised that this works despite not adding the contents: read permission. But as the workflow works this is apparently not strictly necessary.
Although, the documentation says:
If you specify the access for any of these scopes, all of those that are not specified are set to none.
It's a bit strange but I think we can leave it like this for now.
Provide reusable maven ci workflow.
Publish
maven-confandorg.eclipse.theia.cloud.common.Publish
org.eclipse.theia.cloud.operatorandorg.eclipse.theia.cloud.service.Always resolve
org.eclipse.theia.cloud.commonlocally.Update
actions/setup-java@v3toactions/setup-java@v4.Successful publish runs (hardcoded to run on PR):
maven-conf
common
operator
service
Some observations/questions: