Make version of oauth2 proxy configurable via operator param #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids always using the latest image. For example if there are breaking changes. Defaults to latest.
...theia.cloud.operator/src/main/java/org/eclipse/theia/cloud/operator/TheiaCloudArguments.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids always using the latest image.
For example if there are breaking changes.
Defaults to latest.
Linked helm repo PR: eclipse-theia/theia-cloud-helm#44
To test build the operator, create a deployment using the helm chart from the link above and make sure to use keycloak.
When creating a session, the pod should contain the oauth2 proxy with the version you specified in the helm chart.
Note: This was originally brought up, because we had issues with the 7.5.0 version of the oauth2 proxy. I can however, no longer reproduce them. So testing any reasonably new version should work.