Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the PlatformConfigurationFactory a component #1653

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 15, 2024

Currently the activator created the factory (but only register it as a plain service) and on the other hand the BundleGroupComponent then access the activator in a static way.

This now decouples the Factory and BundleGroupComponent from the activator by making them components.

Due to

one can only see if it really works in a deployed product, so beside checking the basic things this also needs to be validated after the next I-build.

Relates to

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

update/org.eclipse.update.configurator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7491258401ae31014fac1d4fd6317a35b56d962c Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sun, 15 Dec 2024 06:53:30 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
index a6c33e27e8..5f045c7318 100644
--- a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
+++ b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.update.configurator; singleton:=true
-Bundle-Version: 3.5.500.qualifier
+Bundle-Version: 3.5.600.qualifier
 Bundle-Activator: org.eclipse.update.internal.configurator.ConfigurationActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Dec 15, 2024

Test Results

 1 755 files  ±0   1 755 suites  ±0   1h 27m 0s ⏱️ - 6m 46s
 4 170 tests ±0   4 148 ✅ ±0   22 💤 ±0  0 ❌ ±0 
13 107 runs  ±0  12 943 ✅ ±0  164 💤 ±0  0 ❌ ±0 

Results for commit ca10afa. ± Comparison against base commit 5d8ee71.

♻️ This comment has been updated with latest results.

Currently the activator created the factory (but only register it as a
plain service) and on the other hand the BundleGroupComponent then
access the activator in a static way.

This now decouples the Factory and BundleGroupComponent from the
activator by making them components.

Fix eclipse-platform#1572
@laeubi laeubi force-pushed the make_factory_component branch from d15bab6 to ca10afa Compare December 15, 2024 07:32
@laeubi
Copy link
Contributor Author

laeubi commented Dec 15, 2024

I now verified with a debugger that the configuration is only read when it is first requested (in this case by BundleGroupComponent)

@laeubi laeubi merged commit 8b8afca into eclipse-platform:master Dec 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants