FAST Output Description and WEIO pip install fix (issues #27 and #28) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank for doing that, this looks good. The writing in ascii format now seem to assume a dataframe, maybe we can do two cases, one if self.data is a dataframe, and another one (the previous one) otherwise (array or list of list). |
ebranlard
changed the title
|
c45f8ca pushed to intergrate your comment @ebranlard |
|
Thanks a lot for doing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast_output_file.pyto preserve description feature in read and write.setup.pyto be able to install weio as a pypi package