Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RbsrStore trait #49

Merged
merged 12 commits into from
Aug 30, 2024
Merged

Add RbsrStore trait #49

merged 12 commits into from
Aug 30, 2024

Conversation

sgwilym
Copy link
Contributor

@sgwilym sgwilym commented Aug 22, 2024

As described by #21 (comment):

  • internal (for replication)
    • all of the public-facing functionality may also be used internally
    • query entries by 3dRange
      • yields Entry, AuthorisationToken, available payload prefix (length)
      • option to filter out results with incomplete payloads (?)
      • optionally order according to the ReconciliationAnnounceEntries:will_sort field
      • optionally as a subscription (?)
    • summarise 3dRange (count, fingerprint)
    • convert area of interest to 3dRange

to be merged into #48

@sgwilym sgwilym added the enhancement New feature or request label Aug 22, 2024
@sgwilym sgwilym requested a review from AljoschaMeyer August 22, 2024 13:17
@sgwilym
Copy link
Contributor Author

sgwilym commented Aug 24, 2024

note to self: this trait should be moved into a new WGPS crate.

data-model/src/store.rs Outdated Show resolved Hide resolved
Base automatically changed from store-trait-query to store August 27, 2024 14:04
Base automatically changed from store to main August 30, 2024 10:33
@sgwilym sgwilym requested a review from AljoschaMeyer August 30, 2024 10:43
@sgwilym sgwilym merged commit f614d1f into main Aug 30, 2024
14 checks passed
@sgwilym sgwilym deleted the store-trait-internal branch August 30, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants