Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week I naïvely thought: "let's quickly port the willow-utils path successor functions and get that out of the way". Things did not work out that way!
TL;DR: All path successor implementations up to this point are wrong, and we were only able to find out how using fuzz testing. willow-util's implementations need to be fixed, as it may be generating the wrong ranges for areas.
SubspaceId
successor
method.PathComponent
traitnew_with_tail
methodempty
methodtry_append_zero_byte
methodset_byte
methodtry_increment_fixed_width
methodprefix_successor
methodPath
traitcomponents
method must implementExactSizeIterator
andDoubleEndedIterator
component_count
methodis_empty
methodis_prefix_of
successor
methodsuccessor_of_prefix
methodOrd
,PartialOrd
Testing
Arbitrary
forPathComponentBox
Arbitrary
forPathRc
Path::successor
Path::successor_of_prefix