Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make IncomingEvent.guild and IncomingEvent.channel nullable #13

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: make IncomingEvent.guild and IncomingEvent.channel nullable #13

merged 1 commit into from
Oct 25, 2024
+2 −0

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Oct 25, 2024

In addition to the Emoji.animated field, I had to make these nullable to get my Rust plugin to work.

chrisdickinson
chrisdickinson approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@chrisdickinson chrisdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisdickinson chrisdickinson merged commit 5626725 into main Oct 25, 2024
2 checks passed
@zshipko zshipko deleted the nullable-fields branch October 25, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdickinson chrisdickinson chrisdickinson approved these changes

@bhelx bhelx Awaiting requested review from bhelx bhelx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zshipko @chrisdickinson