fix(bonsai-core): work around indexer race condition by managing websocket value lifecycles more clearly #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
reviewed
Jan 9, 2025
jaredvu
reviewed
Jan 9, 2025
jaredvu
reviewed
Jan 9, 2025
jaredvu
reviewed
Jan 9, 2025
jaredvu
reviewed
Jan 9, 2025
| @@ -229,16 +233,15 @@ export function setUpParentSubaccount(store: RootStore) { | |||
| if (!isTruthy(wallet) || subaccount == null) { | |||
There was a problem hiding this comment.
yeah I like being extra safe with this one even though technically it can't be null
jaredvu
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we keep all subscriptions open for an extra 20 seconds to prevent churn. Before if you flipped back and forth quickly (sub, unsub, resub) you'd run into weird race conditions and break things. Now when you unsub we hold onto that subscription for 20 seconds and then destroy it. If you re-sub before destruction we just hand you back the sub we kept around.