feat(bonsai-core): bonsai ontology #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tyleroooo
commented
Dec 20, 2024
| @@ -42,6 +42,17 @@ | |||
| "no-multi-assign": "off", | |||
| "no-nested-ternary": "off", | |||
| "no-param-reassign": ["error", { "props": false }], | |||
| "no-restricted-imports": [ | |||
There was a problem hiding this comment.
no importing from abacus-ts except from lib and ontology and summaryTypes
tyleroooo
commented
Dec 20, 2024
src/abacus-ts/ontology.ts
Outdated
|
|
||
| // all data should be accessed via selectrs in this file | ||
| // no files outside abacus-ts should access anything within abacus-ts except this file | ||
| export const MegalodonCore = { |
There was a problem hiding this comment.
this is meant to be THE place you look up the basic data for displaying the app, the authoritative source, the root of all other selectors
There was a problem hiding this comment.
one downside is that this will break tree shaking for everyone who uses this object :/
tyleroooo
commented
Dec 20, 2024
src/abacus-ts/ontology.ts
Outdated
| }, | ||
| } as const satisfies NestedSelectors; | ||
|
|
||
| export const MegalodonHelpers = { |
There was a problem hiding this comment.
this is for common derived data, it's allowed to be messier
jaredvu
reviewed
Jan 6, 2025
jaredvu
reviewed
Jan 6, 2025
src/abacus-ts/selectors/assets.ts
Outdated
| import { selectCurrentMarketInfo } from './markets'; | ||
|
|
||
| export const selectAllAssetsInfo = createSelector([selectRawAssetsData], (assets) => | ||
| transformAssetsInfo(assets) | ||
| ); | ||
|
|
||
| export const selectAllAssetsInfoLoading = createSelector( |
jaredvu
approved these changes
Jan 6, 2025
jaredvu
approved these changes
Jan 6, 2025
jaredvu
reviewed
Jan 6, 2025
jaredvu
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.