Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate Market Details page #1381

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Dec 18, 2024

Screen Shot 2024-12-18 at 3 45 42 PM

Migrate CurrentMarketDetails page


Views

  • New: <CurrentMarketDetails2>

    • use abacusTs marketInfo to populate CurrentMarketDetails
  • <InnerPanel> / <MobileInnerPanel>

    • use testflag to conditionally render CurrentMarketDetails2

State

  • abacusTs/calculators/markets

    • move getMarketEffectiveInitialMarginForMarket from subaccounts calculator
    • return displayableAsset, displayableTicker, and effectiveInitialMarginFraction as part of MarketInfo
  • abacusTs/selectors/markets

    • add selectCurrentMarketInfo
  • abacusTs/summaryTypes

    • add displayableAsset, displayableTicker, and effectiveInitialMarginFraction as part of MarketInfo

@jaredvu jaredvu requested a review from a team as a code owner December 18, 2024 23:45
Copy link

linear bot commented Dec 18, 2024

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:04pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:04pm

@tyleroooo
Copy link
Contributor

Everything else looks goooood I think. I've been doing all the replacements in place to make writing/reading the diffs easier. We should get in sync on if we're going to feature flag this or just roll it out. I am inclined to just roll out.

@jaredvu
Copy link
Contributor Author

jaredvu commented Dec 19, 2024

Everything else looks goooood I think. I've been doing all the replacements in place to make writing/reading the diffs easier. We should get in sync on if we're going to feature flag this or just roll it out. I am inclined to just roll out.

Sounds good. I don't mind having partial roll out for some components (this one is quick and easy to clean up + view doesn't have too many lines of code) but if you don't think thats a good idea I can just do in place

@tyleroooo
Copy link
Contributor

I vote we just do it in place. For the rest calls there's not much that could go wrong so it should just work without any issues I think.

src/abacus-ts/summaryTypes.ts Show resolved Hide resolved
src/abacus-ts/calculators/assets.ts Outdated Show resolved Hide resolved
src/abacus-ts/selectors/assets.ts Outdated Show resolved Hide resolved
src/abacus-ts/selectors/markets.ts Outdated Show resolved Hide resolved
src/lib/assetUtils.ts Show resolved Hide resolved
@jaredvu jaredvu merged commit 5cb0dbd into main Dec 19, 2024
9 checks passed
@jaredvu jaredvu deleted the jared/tra-919-market-detailsmetadata-page branch December 19, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants