-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate Market Details page #1381
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Everything else looks goooood I think. I've been doing all the replacements in place to make writing/reading the diffs easier. We should get in sync on if we're going to feature flag this or just roll it out. I am inclined to just roll out. |
Sounds good. I don't mind having partial roll out for some components (this one is quick and easy to clean up + view doesn't have too many lines of code) but if you don't think thats a good idea I can just do in place |
I vote we just do it in place. For the rest calls there's not much that could go wrong so it should just work without any issues I think. |
Migrate CurrentMarketDetails page
Views
New:
<CurrentMarketDetails2>
<InnerPanel>
/<MobileInnerPanel>
State
abacusTs/calculators/markets
getMarketEffectiveInitialMarginForMarket
from subaccounts calculatorabacusTs/selectors/markets
selectCurrentMarketInfo
abacusTs/summaryTypes