Change to enable running two unit tests on MacOS #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seatim
changed the title
boothby
reviewed
May 20, 2022
tests/test_lib.py
Outdated
| @@ -904,7 +872,7 @@ def run_interactive_interrupt(interactive): | |||
| p = multiprocessing.Process( | |||
| target=_long_running_successful_problem, args=(interactive,)) | |||
| p.start() | |||
| time.sleep(.1) | |||
| time.sleep(1) | |||
There was a problem hiding this comment.
See line 858, you might bump the _long_running_successful_problem to time out after 2s
There was a problem hiding this comment.
I made that change locally and tested just now on both Mac and Linux, and the tests still pass.
There was a problem hiding this comment.
Ah, this is a ridiculously complex test. Line 893:
if time.perf_counter() - t0 > .5:
# be a little generous here... but the caller should kill this in way less than .5s
sys.exit(1)I guess we should bump that to 1.5?
There was a problem hiding this comment.
Ah, this is a ridiculously complex test.
😆 It sure is!
I guess we should bump that to 1.5?
Tested that locally and it is safe seems safe and prudent. Will do.
seatim
changed the title
added 5 commits
May 20, 2022 11:59
In my testing on MacOS, the "test_interactive_interrupt" test passed without any changes needed, and the "test_headless_interrupt" test only needed to have this sleep time increased to pass.
The previous commit caused a unit test to fail on Linux. This change fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to a sleep time in one function that is used by two unit tests. That change enables one unit test to pass that was otherwise failing on MacOS. Changing the sleep time does not compromise the integrity of the test, I believe. With all tests now passing on MacOS, the code to skip two tests is not needed, so that code is removed.