Separate out Model class into cython _GraphManager and python Model #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move almost all functionality of the previously cython
Model
class into a new cython_GraphManager
base class that has only private methods. The new pythonModel
class chooses which of these methods to expose publicly. This will aid in adding the newExpression
class which will expose a different set of the methods on_GraphManager
(see #166).Still TODO if we go with this approach:
_GraphManager
methodsStates
,Symbol
,ArraySymbol
etc that have now been moved todwave.optimization.graph_manager