rusk: add new feature & change Dockerfile #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neotamandua
force-pushed
the
neotamandua/change_default_feature
branch
3 times, most recently
from
d4cef69 to
a371760
Compare
|
Question, why don't we compile with archive by default, but disable the archive functionality by default except when we pass a flag on the command line? As far as I know most chains do it this way. And we already do this on some contexts, like the HTTP listener |
This is a more long-term plan. I created an issue for it here: #3053 |
Neotamandua
force-pushed
the
neotamandua/change_default_feature
branch
from
a371760 to
bfe5959
Compare
Neotamandua
changed the title
Neotamandua
force-pushed
the
neotamandua/change_default_feature
branch
from
bfe5959 to
2ed09cd
Compare
HDauven
previously approved these changes
Nov 28, 2024
- add CARGO_FEATURES build-arg to Dockerfile - change README to include new docker build command - adjust workflow to use "archive" build-arg - small improvement on Makefile commands
Neotamandua
force-pushed
the
neotamandua/change_default_feature
branch
from
2ed09cd to
e435dfb
Compare
HDauven
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to support building and running the
ruskbinary in Docker with the archive featureMain changes