Tab swiping #5408

0nko · 2024-12-18T18:04:49Z

Task/Issue URL: https://app.asana.com/0/1207418217763355/1209006734942815/f

Description

This PR includes the complete implementation of the tab-swiping functionality.

Steps to test this PR

Make sure you’ve completed the onboarding!

New tab from long press

Long press on a tabs button
Verify a new tab is opened

New tab from the menu

Tap on the New tab menu item
Verify a new tab is opened

New tab from tab switcher

Go to tab switcher
Tap on the New tab button
Verify a new tab is opened

New tab recreation

Swiping position

Open at least 3 tabs
Select the 1st one in the tab switcher
Swipe to the last one
Go to tab switcher and verify the correct tab is selected
Tap on the 2nd tab
Verify the correct tab is opened

New link

Open any website
Long press on a link to open in new tab
Verify the link is opened in a new tab

New link in the background

Open any website
Long press on a link to open in background tab
Verify the link is opened in a new tab in the background

New link in the background

Make sure the DDG app is the default browser app
Open an app that can open links in custom tabs (i.e. Twitter, Facebook)
Open a link in a custom tab
Verify the link opens correctly
Move the tab to the app
Verify the tab is correctly displayed within the app

Switch to tab

Start typing a site address that’s already opened in another tab
Tap on the “Switch to tab” item
Verify the existing tab with the link is shown instead of opening a new tab

Changing the omnibar position

Open a few tabs
Go to settings and change the omnibar position
The app will reload (the cached sites are cleared)
Swipe through the tabs and verify the load correctly

Bookmarks

Default site

Set some default URL in Settings -> General -> Show on App Launch
Kill the app and relaunch it
Verify the default site is correctly loaded in a new tab
Kill the app and relaunch it
Verify the default site is loaded in the same tab as before (no new tab is added)

…ilability.kt Co-authored-by: Noelia Alcala <[email protected]>

Task/Issue URL: https://app.asana.com/0/1202552961248957/1208659739219426/f ### Description This PR adds a feature flag that will allow us to disable the tab swiping. --------- Co-authored-by: Noelia Alcala <[email protected]>

Task/Issue URL: https://app.asana.com/0/72649045549333/1208648123066959/f ### Description This PR refactors the tab-related code into a separate `TabManager` class to ease the integration of the tab-swiping functionality. The refactoring doesn’t change the existing functionality. ### Steps to test this PR Smoke testing of tab-related functionality is sufficient (changing of tabs in the tab switcher, creating a new tab, etc.) --------- Co-authored-by: Noelia Alcala <[email protected]>

…g-tabs-ff

Task/Issue URL: https://app.asana.com/0/1207418217763355/1208852760335259/f ### Description This PR just caches the feature flag value. I’ve set the scope of the `IsSwipingTabsFeatureEnabled` to `AppScope` because it’s used inside the `TabManager`, which is used across 2 different activities (`BrowserActivity` and `TabSwitcherActivity`). ### Steps to test this PR Testing optional.

Task/Issue URL: https://app.asana.com/0/72649045549333/1208648123066962/f ### Description This PR includes the complete implementation of the tab-swiping functionality. ### Steps to test this PR **Make sure you’ve completed the onboarding!** #### New tab from long press - [x] Long press on a tabs button - [x] Verify a new tab is opened #### New tab from the menu - [x] Tap on the New tab menu item - [x] Verify a new tab is opened #### New tab from tab switcher - [x] Go to tab switcher - [x] Tap on the New tab button - [x] Verify a new tab is opened #### New tab recreation - [x] Open a few tabs - [x] Go to the tab switcher - [x] Add a new tab - [x] Verify a new tab is correctly displayed - [x] Go back to the tab switcher - [x] Close the NTP - [x] Tap on the new tab button - [x] Verify the new tab is correctly opened #### Swiping position - [x] Open at least 3 tabs - [x] Select the 1st one in the tab switcher - [x] Swipe to the last one - [x] Go to tab switcher and verify the correct tab is selected - [x] Tap on the 2nd tab - [x] Verify the correct tab is opened #### New link - [x] Open any website - [x] Long press on a link to open in new tab - [x] Verify the link is opened in a new tab #### New link in the background - [x] Open any website - [x] Long press on a link to open in background tab - [x] Verify the link is opened in a new tab in the background #### New link in the background - [x] Make sure the DDG app is the default browser app - [x] Open an app that can open links in custom tabs (i.e. Twitter, Facebook) - [x] Open a link in a custom tab - [x] Verify the link opens correctly - [x] Move the tab to the app - [x] Verify the tab is correctly displayed within the app #### Switch to tab - [x] Start typing a site address that’s already opened in another tab - [x] Tap on the “Switch to tab” item - [x] Verify the existing tab with the link is shown instead of opening a new tab #### Changing the omnibar position - [x] Open a few tabs - [x] Go to settings and change the omnibar position - [x] The app will reload (the cached sites are cleared) - [x] Swipe through the tabs and verify the load correctly #### Bookmarks - [x] Load a site - [x] Add it to the boorkmarks - [x] Open a different tab - [x] Go to Bookmarks and select the saved boormark - [x] Verify the bookmark loads correctly #### Default site - [x] Set some default URL in Settings -> General -> Show on App Launch - [x] Kill the app and relaunch it - [x] Verify the default site is correctly loaded in a new tab - [x] Kill the app and relaunch it - [x] Verify the default site is loaded in the same tab as before (no new tab is added)

Task/Issue URL: https://app.asana.com/0/72649045549333/1208648123066972/f ### Description This PR adds pixel for tab swiping. ### Steps to test this PR _Change tabs with swiping_ - [x] Add a few tabs - [x] Swipe tabs 3 times - [x] Verify `m_swipe_tabs_used` pixel is fired 3 times - [x] Verify `m_swipe_tabs_used_daily` pixel is fired once _Change tabs with not swiping_ - [x] Add a few tabs - [x] Long press on a tabs button to open a new tab - [x] Go to tab switch - [x] Select a different tab - [x] Add a new tab from the menu - [x] Verify `m_swipe_tabs_used` pixel is never fired

anikiki · 2025-01-02T11:57:06Z

app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt


-    private val viewModel: BrowserViewModel by bindViewModel()
+    val viewModel: BrowserViewModel by bindViewModel()


This should be private.

anikiki · 2025-01-02T12:29:13Z

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -1144,7 +1177,11 @@ class BrowserTabFragment :
        super.onResume()

        if (viewModel.hasOmnibarPositionChanged(omnibar.omnibarPosition)) {
-            requireActivity().recreate()
+            if (swipingTabsFeature.isEnabled) {
+                (requireActivity() as BrowserActivity).clearTabsAndRecreate()


This code can crash the Custom tab. See scenario:

open the DDG app with the Address bar set at the top

open a DDG custom tab from another app

go back to the DDG app and change the Address bar to the bottom

go back to the DG custom tab and see it crashes as there is no BrowserActivity there

Nice catch, thanks! It’s fixed here.

anikiki · 2025-01-02T12:37:32Z

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

        binding.daxDialogOnboardingCtaContent.layoutTransition.enableTransitionType(LayoutTransition.CHANGING)

        webView = layoutInflater.inflate(
            R.layout.include_duckduckgo_browser_webview,
            binding.webViewContainer,
            true,
-        ).findViewById(R.id.browserWebView) as DuckDuckGoWebView
+        ).findViewById<DuckDuckGoWebView>(R.id.browserWebView)!!


!! is not needed, should be removed.

anikiki · 2025-01-02T12:39:59Z

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -773,6 +776,8 @@ class BrowserTabFragment :

    private lateinit var privacyProtectionsPopup: PrivacyProtectionsPopup

+    private fun requireBrowserActivity(): BrowserActivity = requireNotNull(browserActivity)


This is unused, can be removed.

Good catch.

anikiki · 2025-01-02T13:16:14Z

app/src/test/java/com/duckduckgo/app/browser/BrowserViewModelTest.kt

    @Before
    fun before() {
        MockitoAnnotations.openMocks(this)

        doReturn(MutableLiveData<AppEnjoymentPromptOptions>()).whenever(mockAppEnjoymentPromptEmitter).promptType

        configureSkipUrlConversionInNewTabState(enabled = true)
+        swipingTabsFeature.self().setRawStoredState(State(enable = true))


Should we have tests with this feature disabled?
swipingTabsFeature.self().setRawStoredState(State(enable = false))

I set the flag to false by default and only enable it for new tests.

…e it for new tests

# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

0nko · 2025-01-07T18:42:25Z

Thanks for the thorough review @anikiki! I’ve addressed your feedback — ready for another round.

Task/Issue URL: https://app.asana.com/0/0/1208648123066970/f ### Description Adds unit tests for DefaultTabManager. ### Steps to test this PR Run the unit tests and make sure they’re passing.

anikiki

Looks good and works as expected! 🎉

0nko and others added 22 commits November 9, 2024 11:04

Add a new swiping tabs feature flag

990c806

Add a class for checking if tab swiping is enabled

31521ba

Add an interface for checking if tab swiping is enabled

214b4df

Update app/src/main/java/com/duckduckgo/app/browser/RealTabSwipingAva…

ce74105

…ilability.kt Co-authored-by: Noelia Alcala <[email protected]>

Optimize imports

25fce10

Remove the extra class since onboarding check needs to happen reactively

273bbb2

Swiping tabs: Feature flag (#5263)

e23f84b

Task/Issue URL: https://app.asana.com/0/1202552961248957/1208659739219426/f ### Description This PR adds a feature flag that will allow us to disable the tab swiping. --------- Co-authored-by: Noelia Alcala <[email protected]>

Merge branch 'develop' into feature/ondrej/swiping-tabs

6a20a60

Merge branch 'develop' into feature/ondrej/swiping-tabs

1eb1a6e

Merge branch 'develop' into feature/ondrej/swiping-tabs

4ef99cf

Code clean up

4c9cf61

Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/swipin…

6c5820a

…g-tabs-ff

Add a missing call to the callback

4ef2b6d

Merge branch 'develop' into feature/ondrej/swiping-tabs

f577be2

Merge branch 'develop' into feature/ondrej/swiping-tabs

fd40460

Merge branch 'develop' into feature/ondrej/swiping-tabs

2663e84

Merge branch 'develop' into feature/ondrej/swiping-tabs

0f06a07

Move the activity-related tab functionality back to activity

d487aae

0nko requested review from malmstein and anikiki and removed request for malmstein December 20, 2024 13:18

0nko marked this pull request as ready for review December 20, 2024 13:19

0nko added 3 commits December 20, 2024 20:24

Decrease the gap between tabs

3ed8c20

Disable the swiping feature by default

d7c7ca1

Merge branch 'develop' into feature/ondrej/swiping-tabs

3753240

anikiki reviewed Jan 2, 2025

View reviewed changes

anikiki self-assigned this Jan 3, 2025

0nko added 7 commits January 7, 2025 09:27

Merge branch 'develop' into feature/ondrej/swiping-tabs

518a5ca

Make ViewModel Private Again

86ab1aa

Remove unnecessary !!

e4d0ab8

Remove unused code

585fa88

Change the default swiping feature flag value to false and only enabl…

0441e83

…e it for new tests

Fix a crash when omnibar moved in custom tab

803d973

Merge branch 'develop' into feature/ondrej/swiping-tabs

0081249

# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

0nko requested a review from anikiki January 7, 2025 18:42

0nko and others added 4 commits January 8, 2025 10:01

Add an artificial touch to enable webview scrolling

bb2e31b

Merge branch 'develop' into feature/ondrej/swiping-tabs

389b6ff

Only collect commands if the fragment's resumed

030dd42

Swiping tabs: Tests (#5446)

b1fb6d1

Task/Issue URL: https://app.asana.com/0/0/1208648123066970/f ### Description Adds unit tests for DefaultTabManager. ### Steps to test this PR Run the unit tests and make sure they’re passing.

anikiki approved these changes Jan 8, 2025

View reviewed changes

0nko added 3 commits January 10, 2025 11:24

Remove unused code

26dc31b

Disable swiping when in focus mode

dd619c7

Remove redundant single-tab operation

3e84e0d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tab swiping #5408

Tab swiping #5408

0nko commented Dec 18, 2024 •

edited

Loading

anikiki Jan 2, 2025

anikiki Jan 2, 2025

0nko Jan 7, 2025

anikiki Jan 2, 2025

anikiki Jan 2, 2025

0nko Jan 7, 2025

anikiki Jan 2, 2025

0nko Jan 7, 2025

0nko commented Jan 7, 2025

anikiki left a comment


		private val viewModel: BrowserViewModel by bindViewModel()
		val viewModel: BrowserViewModel by bindViewModel()

		@@ -773,6 +776,8 @@ class BrowserTabFragment :

		private lateinit var privacyProtectionsPopup: PrivacyProtectionsPopup

		private fun requireBrowserActivity(): BrowserActivity = requireNotNull(browserActivity)

Tab swiping #5408

Are you sure you want to change the base?

Tab swiping #5408

Conversation

0nko commented Dec 18, 2024 • edited Loading

Description

Steps to test this PR

New tab from long press

New tab from the menu

New tab from tab switcher

New tab recreation

Swiping position

New link

New link in the background

New link in the background

Switch to tab

Changing the omnibar position

Bookmarks

Default site

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0nko commented Jan 7, 2025

anikiki left a comment

Choose a reason for hiding this comment

0nko commented Dec 18, 2024 •

edited

Loading