-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify autofill update credential pixel to include backfilled parameter #5392
Open
CDRussell
wants to merge
1
commit into
feature/craig/autofill_increase_ratio_complete_credential_saves
Choose a base branch
from
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
base: feature/craig/autofill_increase_ratio_complete_credential_saves
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
December 17, 2024 17:40
969ed0e
to
b196a10
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
December 17, 2024 17:41
0223949
to
d147d82
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
December 18, 2024 17:02
b196a10
to
5580d9f
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
3 times, most recently
from
December 18, 2024 17:06
276377c
to
beb9d61
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
December 18, 2024 17:53
5580d9f
to
cfea135
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
December 18, 2024 17:53
beb9d61
to
1113c2c
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
December 18, 2024 18:06
cfea135
to
469dfbf
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
December 18, 2024 18:06
1113c2c
to
a6e3dd9
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
December 19, 2024 10:14
469dfbf
to
b8badc8
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
December 19, 2024 10:14
a6e3dd9
to
3b38a15
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
December 19, 2024 10:17
b8badc8
to
a36b674
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
December 19, 2024 10:17
3b38a15
to
ca2147f
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
December 20, 2024 16:42
a36b674
to
16e1970
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
December 20, 2024 16:42
ca2147f
to
0264894
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
January 10, 2025 15:53
16e1970
to
45867a4
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
January 10, 2025 15:53
0264894
to
ec6f3af
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
January 13, 2025 15:13
45867a4
to
f3882dc
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
January 13, 2025 15:14
ec6f3af
to
438ce4c
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
January 13, 2025 16:18
f3882dc
to
3d3a41e
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
2 times, most recently
from
January 14, 2025 14:50
f6535fe
to
5206a78
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
January 15, 2025 11:06
3d3a41e
to
2e53317
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
January 15, 2025 11:06
5206a78
to
cf5326b
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves
branch
from
January 15, 2025 11:12
2e53317
to
a24930b
Compare
CDRussell
force-pushed
the
feature/craig/autofill_increase_ratio_complete_credential_saves_pixels
branch
from
January 15, 2025 11:13
cf5326b
to
44cbd70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202926619870900/1208976665268815/f
Description
Steps to test this PR
Logcat filter:
message~:"Pixel sent: m.autofill.logins.update.password.inline" | message~:"partial save" | message~:"backfill"
Updating password (with backfilling)
autofill.me
withusername=test
and set a password for it (deleting any others you have)test
Login
button (to simulate a partial save)Login
buttonm_autofill_logins_update_password_inline_displayed
,backfilled=true
m_autofill_logins_update_password_inline_dismissed
,backfilled=true
m_autofill_logins_update_password_inline_confirmed
hasbackfilled=true
Updating password (without backfilling)
autofill.me
withusername=test
and set a password for it (deleting any others you have)test
Login
buttonm_autofill_logins_update_password_inline_displayed
,backfilled=false
m_autofill_logins_update_password_inline_dismissed
,backfilled=false
m_autofill_logins_update_password_inline_confirmed
hasbackfilled=false