Code

Make the VTab interface safe#416

Code

Open

sourcefrog wants to merge 13 commits intoduckdb:mainduckdb/duckdb-rs:mainfrom sourcefrog:safe-vtabsourcefrog/duckdb-rs:safe-vtabCopy head branch name to clipboard

+164-199

Commits

Commits on Dec 21, 2024

• Use ptr::write when writing uninitialized memory

  sourcefrog

  committed
  4fd71ad

  Copy full SHA for 4fd71ad

• Use smaller unsafe blocks

  sourcefrog

  committed
  f109bc9

  Copy full SHA for f109bc9

• Rust BindData/InitData can just use Rust types

  sourcefrog

  committed
  b6df650

  Copy full SHA for b6df650

• Use unsafe blocks inside unsafe fns generated by macro

  Show description for d9b0952
  sourcefrog

  committed
  d9b0952

  Copy full SHA for d9b0952

• Fix unused import

  sourcefrog

  committed
  49c841f

  Copy full SHA for 49c841f

• Better safety docs for vtab methods

  Show description for a032088
  sourcefrog

  committed
  a032088

  Copy full SHA for a032088

• Similar safety fixes in vtab tests

  sourcefrog

  committed
  80c7c0c

  Copy full SHA for 80c7c0c

• VTab::bind and init are now safe

  Show description for 5947f6d
  sourcefrog

  committed
  5947f6d

  Copy full SHA for 5947f6d

• vtab::Free is no longer needed

  Show description for 4103139
  sourcefrog

  committed
  4103139

  Copy full SHA for 4103139

• BindData and InitData should be Send+Sync

  Show description for 843c6e7
  sourcefrog

  committed
  843c6e7

  Copy full SHA for 843c6e7

• Add a safe & typed interface to get bind_data

  sourcefrog

  committed
  6ecbc3c

  Copy full SHA for 6ecbc3c

• Also safely retrieve the init_data

  sourcefrog

  committed
  cf11a09

  Copy full SHA for cf11a09

Commits on Dec 22, 2024

• Add unsafe blocks, rm unnecessary cast

  sourcefrog

  committed
  9400a51

  Copy full SHA for 9400a51