Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access result as cacheable dependency #1372

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Add access result as cacheable dependency #1372

merged 3 commits into from
Nov 10, 2023

Conversation

dulnan
Copy link
Contributor

@dulnan dulnan commented Oct 23, 2023

Fixes #1371

@klausi
Copy link
Contributor

klausi commented Nov 9, 2023

Makes sense, thanks! Can you resolve the conflicts and fix the PHPCS fail by adding param docs?

@klausi
Copy link
Contributor

klausi commented Nov 10, 2023

Will fix coding standards in a small follow-up.

@klausi klausi merged commit 0fdee57 into drupal-graphql:8.x-4.x Nov 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kingdutch Kingdutch Kingdutch left review comments

@klausi klausi klausi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access result from "entity_access" data producer is not added as cacheable dependency
3 participants
@dulnan @klausi @Kingdutch