Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We initially had to revert this PR because of a conflict with ScrollView that was uncovered #24600
We recently vastly simplified the
ScrollView
control on iOS #26763 which looks to have fixed the issue we were running up against.This PR relates to some issues found here #22476 when trying to layout a Button when it's inside a layout that is partly inside the safearea.
The problem we found is that the
MauiView
returns a size fromSizeThatFits
that doesn't include theSafeAreaInsets
. The arrange pass insets itsBounds
and passes this value toCrossPlatformArrange
but theBounds
being used is the size of the children not including theSafeAreaInsets
which means the bounds used for arranging is wrong.You can see from the screenshots below that the
VSL
surrounding the the entry gets arranged incorrectlyComparison
Given the following
XAML
Before
After
Issues Fixed
Fixes #24246