-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve debugger experience #27017
base: main
Are you sure you want to change the base?
Improve debugger experience #27017
Conversation
Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor things. But this little optimization makes me happy!
Thanks for putting this together Pedro!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do things like commands look? Also, maybe we should also do events for Button. HasClicked = (Clicked is not null)
|
||
private protected override string GetDebbugerDisplay() | ||
{ | ||
return $"Text = {Text}, Command = {Command}, " + base.GetDebbugerDisplay(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this look? The command will just be command, so not super useful? Maybe I am wrong tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Gerald Versluis <[email protected]>
Azure Pipelines successfully started running 3 pipeline(s). |
|
||
private protected override string GetDebuggerDisplay() | ||
{ | ||
return $"IsRunning = {IsRunning}, " + base.GetDebuggerDisplay(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interpolating along with string concatenation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it cause any issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it cause any issue?
Typically one uses one or the other for consistency reasons, not both. I think one can do:
$"IsRunning = {IsRunning}, {(base.GetDebuggerDisplay())}";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String concatenation should never be use in modern c#
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
This PR adds the
DebuggerDisplay
attribute over a good amount of controls and, this is the first step into improving the debug experience of .NET MAUIYou can find more images in the related issue
Issues Fixed
Related to #27016