Fixed scrolling issue on ProjectListPage #27005
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
karthikraja-arumugam
added
the
partner/syncfusion
|
@dotnet-policy-service terminate |
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
1 similar comment
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
jfversluis
added
the
area-templates
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PureWeen
requested changes
Jan 9, 2025
|
|
||
| <controls:AddButton | ||
| Command="{Binding AddProjectCommand}" /> | ||
| <CollectionView |
There was a problem hiding this comment.
Could we just put a ScrollView around the VSL?
I think because this page won't really have many elements just keeping a simple BindableLayout is a useful example
There was a problem hiding this comment.
I've updated the code based on your feedback. Could you please review it and let me know if there are any further concerns
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Detail
Scrolling is not working in ProjectListPage.
Root Cause
The ProjectList content was wrapped inside a Grid. Since the Grid layout does not support scrolling, any content exceeding the screen height was not accessible.
Description of Change
Replaced the VerticalStackLayout with a CollectionView in the ProjectListPage.
Tested the behaviour in the following platforms
Issues Fixed
Fixes #26917
Screenshots
ios:
26917Before.mov
26917After.mov
Mac:
MacBefore.mov
MacAfter.mov
Android:
AndroidBefore.mov
AndroidAfter.mov
Windows:
WindowsBefore.mov
WindowsAfter1.mov